Adapt some pages to ReScript 11 including records and variants #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Oct 21, 2023
zth
reviewed
Oct 21, 2023
zth
reviewed
Oct 21, 2023
zth
reviewed
Oct 21, 2023
zth
approved these changes
Oct 21, 2023
|
@zth I assigned you to some new issues. |
|
@fhammerschmidt tests seem to fail, but otherwise this should be good to go, right? |
|
I have another branch open to fix the tests. Should be no problem to merge for now since it is not the main branch anyway. |
zth
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Adapt some pages to ReScript 11 including records and variants * Some better wordings * Variants: Add some TODOs
zth
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Adapt some pages to ReScript 11 including records and variants * Some better wordings * Variants: Add some TODOs
fhammerschmidt
added a commit
to fhammerschmidt/rescript-lang.org
that referenced
this pull request
Nov 14, 2023
…ipt-lang#730) * Adapt some pages to ReScript 11 including records and variants * Some better wordings * Variants: Add some TODOs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.